Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fatal $sql_values string to array #8432

Merged
merged 1 commit into from Oct 23, 2017
Merged

Fix fatal $sql_values string to array #8432

merged 1 commit into from Oct 23, 2017

Conversation

marekhanus
Copy link
Contributor

@marekhanus marekhanus commented Oct 22, 2017 •
edited by eternoendless

Questions Answers
Branch? 1.7.2.x
Description? PHP Fatal error: Uncaught Error: [] operator not supported for strings in
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? Adding products via Webservice cause fatal errors

This change is Reviewable

@prestonBot
Copy link
Collaborator

Hello marekhanus!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi!

Your pull request description seems to be incomplete or malformed:

  • The description shouldn't be empty.
  • The type should be one of: new feature, improvement, bug fix, refacto or critical.
  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

Quetzacoalt91
Quetzacoalt91 approved these changes Oct 23, 2017
View reviewed changes
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.3.0 milestone Oct 23, 2017
@Quetzacoalt91 Quetzacoalt91 merged commit aa5124d into PrestaShop:develop Oct 23, 2017
@eternoendless eternoendless changed the title CO: Fix fatal $sql_values string to array Fix fatal $sql_values string to array Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marekhanus @prestonBot @Quetzacoalt91